Re: [PATCH 2/2] [media] saa7134: Remove unused status var

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/23/14 12:59, Mauro Carvalho Chehab wrote:
> drivers/media/pci/saa7134/saa7134-go7007.c: In function ‘saa7134_go7007_interface_reset’:
> drivers/media/pci/saa7134/saa7134-go7007.c:147:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>

Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

	Hans

> 
> diff --git a/drivers/media/pci/saa7134/saa7134-go7007.c b/drivers/media/pci/saa7134/saa7134-go7007.c
> index d9af6f3dc8af..4f63e1ddbb68 100644
> --- a/drivers/media/pci/saa7134/saa7134-go7007.c
> +++ b/drivers/media/pci/saa7134/saa7134-go7007.c
> @@ -144,7 +144,6 @@ static int saa7134_go7007_interface_reset(struct go7007 *go)
>  {
>  	struct saa7134_go7007 *saa = go->hpi_context;
>  	struct saa7134_dev *dev = saa->dev;
> -	u32 status;
>  	u16 intr_val, intr_data;
>  	int count = 20;
>  
> @@ -162,8 +161,8 @@ static int saa7134_go7007_interface_reset(struct go7007 *go)
>  	saa_clearb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
>  	saa_setb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
>  
> -	status = saa_readb(SAA7134_GPIO_GPSTATUS2);
> -	/*pr_debug("status is %s\n", status & 0x40 ? "OK" : "not OK"); */
> +	saa_readb(SAA7134_GPIO_GPSTATUS2);
> +	/*pr_debug("status is %s\n", saa_readb(SAA7134_GPIO_GPSTATUS2) & 0x40 ? "OK" : "not OK"); */
>  
>  	/* enter command mode...(?) */
>  	saa_writeb(SAA7134_GPIO_GPSTATUS2, GPIO_COMMAND_REQ1);
> @@ -172,7 +171,7 @@ static int saa7134_go7007_interface_reset(struct go7007 *go)
>  	do {
>  		saa_clearb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
>  		saa_setb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
> -		status = saa_readb(SAA7134_GPIO_GPSTATUS2);
> +		saa_readb(SAA7134_GPIO_GPSTATUS2);
>  		/*pr_info("gpio is %08x\n", saa_readl(SAA7134_GPIO_GPSTATUS0 >> 2)); */
>  	} while (--count > 0);
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux