Em Sun, 31 Aug 2014 13:35:12 +0200 Matthias Schwarzott <zzam@xxxxxxxxxx> escreveu: > The new file has a different name: dvb-demod-si2165-D.fw > > Count blocks instead of reading count from extra header. > Calculate CRC during upload and compare result to what chip calcuated. > Use 0x01 instead of real patch version, because this is only used to > check if something was uploaded but not to check the version of it. > > Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx> > --- ... > diff --git a/drivers/media/dvb-frontends/si2165_priv.h b/drivers/media/dvb-frontends/si2165_priv.h > index 2b70cf1..fd778dc 100644 > --- a/drivers/media/dvb-frontends/si2165_priv.h > +++ b/drivers/media/dvb-frontends/si2165_priv.h > @@ -18,6 +18,6 @@ > #ifndef _DVB_SI2165_PRIV > #define _DVB_SI2165_PRIV > > -#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165.fw" > +#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165-D.fw" Please, don't do that. Changing the name of the firmware and breaking the format is a bad idea, specially since you're not supporting anymore the legacy one. I would be ok if you were not breaking support for the old firmware file. Also, better to use lowercase for the firmware name. PS.: I'm not applying patch 6/7 as this got rejected. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
