Re: au0828_init_tuner() called without dev lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/22/2014 10:37 AM, Hans Verkuil wrote:
> On 09/22/2014 06:31 PM, Shuah Khan wrote:
>> Hi Hans and Mauro,
>>
>> While I was making changes for media token work, I noticed there are
>> several places au0828_init_tuner() gets called without holding dev lock.
> 
> au0828 sets the lock pointer in struct video_device to the dev lock.
> That means that all v4l2 ioctl calls are serialized in v4l2_ioctl()
> in v4l2-dev.c. So these calls *do* hold the device lock.
> 
> Not au0828_v4l2_resume() though, that's not an ioctl op.
> 

Good. I will go ahead and fix au0828_v4l2_resume() to do
it right.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux