Hi Kiran, > From: Kiran AVND [mailto:avnd.kiran@xxxxxxxxxxx] > Sent: Monday, September 15, 2014 8:43 AM > > sysmmu will control mfc device clock on/off wherever > needed. Explicit clock on/off in the driver is not needed > anymore. Remove such reduntant clock on/off in the driver. What if... iommu is not used? MFC can work with either iommu or CMA. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > > Signed-off-by: Kiran AVND <avnd.kiran@xxxxxxxxxxx> > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 -- > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 6 ------ > 2 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c > b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index f4cb7f2..3a1f97e 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -883,7 +883,6 @@ static int s5p_mfc_release(struct file *file) > > mfc_debug_enter(); > mutex_lock(&dev->mfc_mutex); > - s5p_mfc_clock_on(); > vb2_queue_release(&ctx->vq_src); > vb2_queue_release(&ctx->vq_dst); > /* Mark context as idle */ > @@ -906,7 +905,6 @@ static int s5p_mfc_release(struct file *file) > mfc_err("Power off failed\n"); > } > mfc_debug(2, "Shutting down clock\n"); > - s5p_mfc_clock_off(); > dev->ctx[ctx->num] = NULL; > s5p_mfc_dec_ctrls_delete(ctx); > v4l2_fh_del(&ctx->fh); > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > index ca4b69f9..d0bdbfb 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > @@ -487,8 +487,6 @@ static int reqbufs_output(struct s5p_mfc_dev *dev, > struct s5p_mfc_ctx *ctx, > { > int ret = 0; > > - s5p_mfc_clock_on(); > - > if (reqbufs->count == 0) { > mfc_debug(2, "Freeing buffers\n"); > ret = vb2_reqbufs(&ctx->vq_src, reqbufs); > @@ -525,7 +523,6 @@ static int reqbufs_output(struct s5p_mfc_dev *dev, > struct s5p_mfc_ctx *ctx, > ret = -EINVAL; > } > out: > - s5p_mfc_clock_off(); > if (ret) > mfc_err("Failed allocating buffers for OUTPUT queue\n"); > return ret; > @@ -536,8 +533,6 @@ static int reqbufs_capture(struct s5p_mfc_dev *dev, > struct s5p_mfc_ctx *ctx, > { > int ret = 0; > > - s5p_mfc_clock_on(); > - > if (reqbufs->count == 0) { > mfc_debug(2, "Freeing buffers\n"); > ret = vb2_reqbufs(&ctx->vq_dst, reqbufs); > @@ -579,7 +574,6 @@ static int reqbufs_capture(struct s5p_mfc_dev *dev, > struct s5p_mfc_ctx *ctx, > ret = -EINVAL; > } > out: > - s5p_mfc_clock_off(); > if (ret) > mfc_err("Failed allocating buffers for CAPTURE queue\n"); > return ret; > -- > 1.7.3.rc2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
