On 09/13/2014 02:34 AM, Shuah Khan wrote: > Mauro/Hans, > > It turns out au0828 driver does init tuner from its > v4l2_fops read and poll. If an analog app comes in > and does a read or poll, digital could get disrupted. > Do you recommend adding token access to these?? Yes. read() and poll() are effectively the same as STREAMON. But rather than doing this for read, poll, streamon, streamoff and when the filehandle is closed you should think of integrating this in vb2 and do it in start_streaming and stop_streaming. Those are really the only two streaming-related places where you need to take and release the tuner token. As I mentioned before, I think it is a good idea to convert au0828 to vb2. Since vb2 makes resource management so much easier than vb1 I think it will only help you. Also, requiring vb2 support for tuner ownership to work correctly is a good incentive to keep on converting drivers to vb2. Regards, Hans > > -- Shuah > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
