Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:58 Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > The 'write' argument is very ambiguous. I first assumed that if it is 1, > then we're doing video output but instead it meant the reverse. > > Since it is used to setup the dma_dir value anyway it is now replaced by > the correct dma_dir value which is unambiguous. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Given my comments to one of your earlier patches, I can only agree with you here :-) Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> However, how about moving this patch up in the series, before adding the write argument to the alloc function ? > --- > drivers/media/v4l2-core/videobuf2-core.c | 15 +++++---- > drivers/media/v4l2-core/videobuf2-dma-contig.c | 46 ++++++++++++----------- > drivers/media/v4l2-core/videobuf2-dma-sg.c | 46 +++++++++++------------ > drivers/media/v4l2-core/videobuf2-vmalloc.c | 20 ++++++----- > include/media/videobuf2-core.h | 11 +++--- > 5 files changed, 73 insertions(+), 65 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
