Hi, On Tuesday, September 09, 2014 03:54:04 PM Mauro Carvalho Chehab wrote: > This driver depends on a legacy OMAP DMA API. So, it won't > compile-test on other archs. > > While we might add stubs to the functions, this is not a > good idea, as the hole API should be replaced. This is also not a good idea becaouse it would break the driver for OMAP1 once somebody enables COMPILE_TEST option while also having ARCH_OMAP1 enabled (which is perfectly fine and shouldn't cause the driver breakage). In general COMPILE_TEST option is completely independent from the arch specific ones and it should not change behaviour of the existing code. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > So, for now, let's just remove COMPILE_TEST and wait for > some time for people to fix. If not fixed, then we'll end > by removing this driver as a hole. > > Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> > > diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig > index 6af6c6dccda8..f2776cd415ca 100644 > --- a/drivers/media/platform/soc_camera/Kconfig > +++ b/drivers/media/platform/soc_camera/Kconfig > @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU > config VIDEO_OMAP1 > tristate "OMAP1 Camera Interface driver" > depends on VIDEO_DEV && SOC_CAMERA > - depends on ARCH_OMAP1 || COMPILE_TEST > + depends on ARCH_OMAP1 > depends on HAS_DMA > select VIDEOBUF_DMA_CONTIG > select VIDEOBUF_DMA_SG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
