On 09/05/2014 02:02 AM, Antti Palosaari wrote:
On 09/05/2014 01:50 AM, Daniel Glöckner wrote:
On Fri, Sep 05, 2014 at 12:43:43AM +0300, Antti Palosaari wrote:
+ switch (state->af9033_config[adap->id].tuner) {
+ case AF9033_TUNER_IT9135_38:
+ case AF9033_TUNER_IT9135_51:
+ case AF9033_TUNER_IT9135_52:
+ case AF9033_TUNER_IT9135_60:
+ case AF9033_TUNER_IT9135_61:
+ case AF9033_TUNER_IT9135_62:
+ demod2 = 2;
+ default:
+ demod2 = 1;
+ }
Missing break?
YES! will fix...
It does not have functionality error in that case, but sure it is wrong
and may jump up later when some changes are done.
It is also good example what happens when checking tools, maybe
checkpatch.pl, started whining if switch-case statement has unneeded
break. So lets stop adding break to last case, and this kind of copy
paste mistakes happens surely more often....
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
