Em Thu, 04 Sep 2014 16:54:38 +0200 Hans Verkuil <hansverk@xxxxxxxxx> escreveu: > I'll need to review this as well. Perhaps tw_writel should expect a __le32? There are several other parts where it is using the address as CPU endian. Anyway, if you have some BE system, then you can test the board there and see what would work. Regards, Mauro > > Hans > > On 09/04/14 16:46, Mauro Carvalho Chehab wrote: > > drivers/media/pci/tw68/tw68-video.c:351:9: warning: incorrect type in argument 1 (different base types) > > drivers/media/pci/tw68/tw68-video.c:351:9: expected unsigned int [unsigned] val > > drivers/media/pci/tw68/tw68-video.c:351:9: got restricted __le32 [usertype] <noident> > > > > Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> > > > > diff --git a/drivers/media/pci/tw68/tw68-video.c b/drivers/media/pci/tw68/tw68-video.c > > index 66fae2345fdd..4dd38578cf1b 100644 > > --- a/drivers/media/pci/tw68/tw68-video.c > > +++ b/drivers/media/pci/tw68/tw68-video.c > > @@ -348,7 +348,7 @@ int tw68_video_start_dma(struct tw68_dev *dev, struct tw68_buf *buf) > > * a new address can be set. > > */ > > tw_clearl(TW68_DMAC, TW68_DMAP_EN); > > - tw_writel(TW68_DMAP_SA, cpu_to_le32(buf->dma)); > > + tw_writel(TW68_DMAP_SA, (__force u32)cpu_to_le32(buf->dma)); > > /* Clear any pending interrupts */ > > tw_writel(TW68_INTSTAT, dev->board_virqmask); > > /* Enable the risc engine and the fifo */ > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
