Em Thu, 14 Aug 2014 11:54:02 +0200
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> These values make no sense. All SDTV standards have the same width.
> This seems to be copied from the cx88 driver. Just drop these weird
> values.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> drivers/media/pci/cx23885/cx23885.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/cx23885/cx23885.h b/drivers/media/pci/cx23885/cx23885.h
> index 99a5fe0..f542ced 100644
> --- a/drivers/media/pci/cx23885/cx23885.h
> +++ b/drivers/media/pci/cx23885/cx23885.h
> @@ -610,15 +610,15 @@ extern int cx23885_risc_databuffer(struct pci_dev *pci,
>
> static inline unsigned int norm_maxw(v4l2_std_id norm)
> {
> - return (norm & (V4L2_STD_MN & ~V4L2_STD_PAL_Nc)) ? 720 : 768;
> + return 720;
Not sure if you checked cx23885 datasheet. I didn't, but I don't doubt
that it uses about the same A/D logic as cx88.
In the case of cx88, the sampling rate for a few standards is different,
as recommended at the datasheet. This is done to provide the highest
image quality, as there are some customized filters for some standards,
but they require some specific sampling rates. That's why PAL-Nc and
NTSC/PAL-M are handled on a different way.
> }
>
> static inline unsigned int norm_maxh(v4l2_std_id norm)
> {
> - return (norm & V4L2_STD_625_50) ? 576 : 480;
> + return (norm & V4L2_STD_525_60) ? 480 : 576;
This is obviously wrong.
> }
>
> static inline unsigned int norm_swidth(v4l2_std_id norm)
> {
> - return (norm & (V4L2_STD_MN & ~V4L2_STD_PAL_Nc)) ? 754 : 922;
> + return 754;
> }
Same as above commented.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
