Re: [git:media_tree/master] [media] atmel-isi: Fix a truncate warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Aug 2014, Mauro Carvalho Chehab wrote:

> This is an automatic generated email to let you know that the following patch were queued at the 
> http://git.linuxtv.org/media_tree.git tree:
> 
> Subject: [media] atmel-isi: Fix a truncate warning
> Author:  Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> Date:    Fri Aug 22 05:53:27 2014 -0500
> 
>    drivers/media/platform/soc_camera/atmel-isi.c: In function 'start_streaming':
>    drivers/media/platform/soc_camera/atmel-isi.c:397:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>      isi_writel(isi, ISI_INTDIS, ~0UL);
>                              ^
> 
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> 
>  drivers/media/platform/soc_camera/atmel-isi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> ---
> 
> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=9842a417d46bf40f2d460120016b6392d3ac32c9
> 
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
> index f87012b..96a4b11 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -394,7 +394,7 @@ static int start_streaming(struct vb2_queue *vq, unsigned int count)
>  		return ret;
>  	}
>  	/* Disable all interrupts */
> -	isi_writel(isi, ISI_INTDIS, ~0UL);
> +	isi_writel(isi, ISI_INTDIS, (u32)~0UL);

Uhm... Wouldn't it have been much better to just remove the 'L' above to 
make it "~0U" ?.. Too late, I guess.

Thanks
Guennadi

>  
>  	spin_lock_irq(&isi->lock);
>  	/* Clear any pending interrupt */
> 
> _______________________________________________
> linuxtv-commits mailing list
> linuxtv-commits@xxxxxxxxxxx
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux