On 09/02/2014 09:21 PM, Mauro Carvalho Chehab wrote: > Em Tue, 26 Aug 2014 08:33:12 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> Add support for the tw68 driver. The driver has been out-of-tree for many >> years on gitorious: https://gitorious.org/tw68/tw68-v2 >> >> I have refactored and ported that driver to the latest V4L2 core frameworks. >> >> Tested with my Techwell tw6805a and tw6816 grabber boards. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > I would be expecting here the William M. Brack's SOB too. Sorry, that's not possible. The only email I have no longer works. I googled to see if I could find another email without success. I met him years ago during an ELC and he was a retired engineer, so he may not even be around anymore. His gitorious.org repo has been inactive for over two years. > > Also, the best is to add his original work on one patch (without Kbuild > stuff) and your changes on a separate patch. That helps us to identify > what are your contributions to his code, and what was his original > copyright wording. Are you sure you want that in the mainline kernel? His code is in gitorious, a link to that is in the commit log. I'm not too keen to add code to the kernel which is promptly being overwritten by another version. An alternative might be to add a link to that repo to tw68-core.c as well so that it is not just in the commit log but also in the source code. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html