Re: [PATCH 1/3] media: fix kernel deadlock due to tuner pull-out while playing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Changbing,

All 3 patches on this series seem OK on my eyes. I'll do some tests with them
and see what happens.

Yet, there are some issues on the way you're sending the patches.

First of all, it seems that patchwork is messing with your From:, removing
your name. I just fixed it there.

Em Thu, 21 Aug 2014 10:04:25 +0800
Changbing Xiong <cb.xiong@xxxxxxxxxxx> escreveu:

> Enviroment: odroidx2 + Hauppauge(WinTV-Aero-M)
> Normally, ADAP_STREAMING bit is set in dvb_usb_start_feed and cleared in dvb_usb_stop_feed.
> But in exceptional cases, for example, when the tv is playing programs, and the tuner is pulled out.
> then dvb_usbv2_disconnect is called, it will first call dvb_usbv2_adapter_frontend_exit to stop
> dvb_frontend_thread, and then call dvb_usbv2_adapter_dvb_exit to clear ADAP_STREAMING bit, At this point,
> if dvb_frontend_thread is sleeping and wait for ADAP_STREAMING to be cleared to get out of sleep.
> then dvb_frontend_thread can never be stoped, because clearing ADAP_STREAMING bit is performed after
> dvb_frontend_thread is stopped(i.e. performed in dvb_usbv2_adapter_dvb_exit), So deadlock becomes true.

Second, please avoid big lines and just one paragraph. I rewrote this.

It is really boring and harder to understand when it is like that. Also,
we generally use no more than 72 cols on the patches, as we want to be
able to read them well with 80 cols standard tty terminals.

See the patch that will be merged.

>  drivers/media/usb/dvb-usb-v2/dvb_usb_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 drivers/media/usb/dvb-usb-v2/dvb_usb_core.c

Third, why are you changing the mode on all your 3 patches?

It makes no sense to transform a .c file into an exec file.

No need to further action from you, as I already fixed them when
applying, but please fix your environment to avoid future rework
from the maintainers.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux