RE: [PATCH v2 27/35] [media] s5p-jpeg: Get rid of a warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

A subsequent patch by Jacek Anaszewski [1] is resoling this problem in
a better way. If you don't mind I will take his patch.

[1] [1/4] s5p-jpeg: Avoid assigning readl result
    https://patchwork.linuxtv.org/patch/25661/

Best wishes,
-- 
Kamil Debski
Samsung R&D Institute Poland


> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Mauro Carvalho Chehab
> Sent: Tuesday, August 26, 2014 11:55 PM
> 
> drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c: In function
> 's5p_jpeg_clear_int':
> drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c:327:16: warning: variable
> 'reg' set but not used [-Wunused-but-set-variable]
>   unsigned long reg;
>                 ^
> 
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> ---
>  drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
> b/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
> index 52407d790726..0d37bed088df 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c
> @@ -326,7 +326,7 @@ void s5p_jpeg_clear_int(void __iomem *regs)  {
>  	unsigned long reg;
> 
> -	reg = readl(regs + S5P_JPGINTST);
> +	readl(regs + S5P_JPGINTST);
>  	writel(S5P_INT_RELEASE, regs + S5P_JPGCOM);
>  	reg = readl(regs + S5P_JPGOPR);
>  }
> --
> 1.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media"
> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
> info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux