2014-08-27 15:03 GMT+02:00 Hans Verkuil <hverkuil@xxxxxxxxx>: > On 08/27/14 14:53, jean-michel.hautbois@xxxxxxxxxxx wrote: >> From: Jean-Michel Hautbois <jean-michel.hautbois@xxxxxxxxxxx> >> >> This patch adds support for DT parsing of register maps adresses. >> This allows multiple adv76xx devices on the same bus. >> >> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/media/i2c/adv7604.txt | 12 ++++ >> drivers/media/i2c/adv7604.c | 71 ++++++++++++++++++---- >> 2 files changed, 71 insertions(+), 12 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> index c27cede..33881fb 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt >> @@ -32,6 +32,18 @@ The digital output port node must contain at least one endpoint. >> Optional Properties: >> >> - reset-gpios: Reference to the GPIO connected to the device's reset pin. >> + - adv7604-page-avlink: Programmed address for avlink register map >> + - adv7604-page-cec: Programmed address for cec register map >> + - adv7604-page-infoframe: Programmed address for infoframe register map >> + - adv7604-page-esdp: Programmed address for esdp register map >> + - adv7604-page-dpp: Programmed address for dpp register map >> + - adv7604-page-afe: Programmed address for afe register map >> + - adv7604-page-rep: Programmed address for rep register map >> + - adv7604-page-edid: Programmed address for edid register map >> + - adv7604-page-hdmi: Programmed address for hdmi register map >> + - adv7604-page-test: Programmed address for test register map >> + - adv7604-page-cp: Programmed address for cp register map >> + - adv7604-page-vdp: Programmed address for vdp register map > > Might adv7604-addr-avlink be a better name? Other than that it looks good > to me. > > Hans > I can replace all -page- by -addr- if it seems better... I used page as this is also the name defined in the source code but you are probably right, it is an address, not a page... :) JM -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html