Indeed, the patch is correct, but the description should say: em28xx: add ts mode setting for PCTV 292e TS mode must be set in the existing PCTV 292e driver. Thanks for your reviews! On 13 August 2014 02:23, Antti Palosaari <crope@xxxxxx> wrote: > Acked-by: Antti Palosaari <crope@xxxxxx> > Reviewed-by: Antti Palosaari <crope@xxxxxx> > > PCTV 461e is satellite receiver whilst that one should be PCTV 292e. I will > fix the type, no new patch needed. > > Antti > > > On 08/11/2014 10:58 PM, Olli Salonen wrote: >> >> TS mode must be set in the existing PCTV 461e driver. >> >> Signed-off-by: Olli Salonen <olli.salonen@xxxxxx> >> --- >> drivers/media/usb/em28xx/em28xx-dvb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c >> b/drivers/media/usb/em28xx/em28xx-dvb.c >> index d8e9760..0645793 100644 >> --- a/drivers/media/usb/em28xx/em28xx-dvb.c >> +++ b/drivers/media/usb/em28xx/em28xx-dvb.c >> @@ -1535,6 +1535,7 @@ static int em28xx_dvb_init(struct em28xx *dev) >> /* attach demod */ >> si2168_config.i2c_adapter = &adapter; >> si2168_config.fe = &dvb->fe[0]; >> + si2168_config.ts_mode = SI2168_TS_PARALLEL; >> memset(&info, 0, sizeof(struct i2c_board_info)); >> strlcpy(info.type, "si2168", I2C_NAME_SIZE); >> info.addr = 0x64; >> > > -- > http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html