Hi Kamil, Am Dienstag, den 05.08.2014, 17:36 +0200 schrieb Kamil Debski: > Hi Philipp, > > I have some errors from checkpatch for this patch. Please fix them. > > ERROR: return is not a function, parentheses are not required > #86: FILE: drivers/media/platform/coda/coda-bit.c:40: > + return (coda_read(dev, CODA_REG_BIT_CUR_PC) != 0); > > WARNING: quoted string split across lines > #681: FILE: drivers/media/platform/coda/coda-bit.c:635: > + v4l2_err(&dev->v4l2_dev, "Wrong firmware. Hw: %s, Fw: %s," > + " Version: %u.%u.%u\n", > WARNING: quoted string split across lines > #695: FILE: drivers/media/platform/coda/coda-bit.c:649: > + v4l2_warn(&dev->v4l2_dev, "Unsupported firmware version: " > + "%u.%u.%u\n", major, minor, releas In my opinion this is not a problem. It is quite clear that the version number(s) are generated, and the rest of the string is greppable. > And many, many following warnings: "WARNING: line over 80 characters". > Please check if these lines *REALLY* need to be such long. This patch only moves code around. I strongly prefer not to make formatting changes at the same time. If you insist, I'll prepend a checkpatch cleanup series, but I'd be happier if you'd let me do this after the move. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
