RE: [PATCH v2 05/11] [media] coda: use CODA_MAX_FRAME_SIZE everywhere

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Checkpatch:
------------------------------
WARNING: line over 80 characters
#41: FILE: drivers/media/platform/coda.c:3109:
+		if (coda_get_bitstream_payload(ctx) >= CODA_MAX_FRAME_SIZE -
512)

-- 
Kamil Debski
Samsung R&D Institute Poland


> -----Original Message-----
> From: Philipp Zabel [mailto:p.zabel@xxxxxxxxxxxxxx]
> Sent: Friday, July 18, 2014 12:23 PM
> To: linux-media@xxxxxxxxxxxxxxx
> Cc: Mauro Carvalho Chehab; Kamil Debski; Fabio Estevam; Hans Verkuil;
> Nicolas Dufresne; kernel@xxxxxxxxxxxxxx; Michael Olbrich; Philipp Zabel
> Subject: [PATCH v2 05/11] [media] coda: use CODA_MAX_FRAME_SIZE
> everywhere
> 
> From: Michael Olbrich <m.olbrich@xxxxxxxxxxxxxx>
> 
> Without this changing CODA_MAX_FRAME_SIZE to anything other than
> 0x100000 can break the bitstram handling
> 
> Signed-off-by: Michael Olbrich <m.olbrich@xxxxxxxxxxxxxx>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/coda.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/coda.c
> b/drivers/media/platform/coda.c index 917727e..141ec29 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -3106,7 +3106,7 @@ static void coda_finish_decode(struct coda_ctx
> *ctx)
>  	 * by up to 512 bytes
>  	 */
>  	if (ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) {
> -		if (coda_get_bitstream_payload(ctx) >= 0x100000 - 512)
> +		if (coda_get_bitstream_payload(ctx) >= CODA_MAX_FRAME_SIZE
> - 512)
>  			kfifo_init(&ctx->bitstream_fifo,
>  				ctx->bitstream.vaddr, ctx->bitstream.size);
>  	}
> --
> 2.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux