Re: Resend: [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 07/08/2014 01:41 PM, Ian Molton wrote:

Resent to include the author and a couple of other interested parties :)

   Thank you (despite you didn't include me :-).

This patch series provides fixes that allow the rcar_vin driver to function
without triggering dozens of warnings from the videobuf2 and soc_camera layers.

Patches 2/3 should probably be merged into a single, atomic change, although
patch 2 does not make the existing situation /worse/ in and of itself.

   Perhaps it's worth to just swap patches 2 & 3...

Patch 4 does not change the code logic, but is cleaner and less prone to
breakage caused by furtutre modification. Also, more consistent with the use of
vb pointers elsewhere in the driver.

   It's not a good practice to post fixes and clean-ups in a single series.

Comments welcome!

   I've just tested the whole series, so here's my:

Tested-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux