On 01.08.2014 17:23, Dan Carpenter wrote:
> Hello Matthias Schwarzott,
>
Hello Dan,
> The patch 3e54a1697ace: "[media] si2165: Add demod driver for DVB-T
> only" from Jul 22, 2014, leads to the following static checker
> warning:
>
> drivers/media/dvb-frontends/si2165.c:329 si2165_wait_init_done()
> warn: signedness bug returning '(-22)'
>
> drivers/media/dvb-frontends/si2165.c
> 315 static bool si2165_wait_init_done(struct si2165_state *state)
> 316 {
> 317 int ret = -EINVAL;
> 318 u8 val = 0;
> 319 int i;
> 320
> 321 for (i = 0; i < 3; ++i) {
> 322 si2165_readreg8(state, 0x0054, &val);
> 323 if (val == 0x01)
> 324 return 0;
>
> This is the success path?
yes it is.
>
> 325 usleep_range(1000, 50000);
> 326 }
> 327 dev_err(&state->i2c->dev, "%s: init_done was not set\n",
> 328 KBUILD_MODNAME);
> 329 return ret;
>
> -EINVAL becomes 1 when casted to bool.
I already noticed this and prepared a patch to change the return type to
int.
This will be sent the next days.
Regards
Matthias
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
