Am Montag, den 21.07.2014, 16:04 -0300 schrieb Mauro Carvalho Chehab:
> Em Fri, 11 Jul 2014 11:36:29 +0200
> Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> escreveu:
>
> > From: Michael Olbrich <m.olbrich@xxxxxxxxxxxxxx>
> >
> > Some drivers might allow to decode remaining frames from an internal ringbuffer
> > after a decoder stop command. Allow those to call v4l2_m2m_try_schedule
> > directly.
> >
> > Signed-off-by: Michael Olbrich <m.olbrich@xxxxxxxxxxxxxx>
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > ---
> > drivers/media/v4l2-core/v4l2-mem2mem.c | 3 ++-
> > include/media/v4l2-mem2mem.h | 2 ++
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
> > index 178ce96..5f5c175 100644
> > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c
> > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
> > @@ -208,7 +208,7 @@ static void v4l2_m2m_try_run(struct v4l2_m2m_dev *m2m_dev)
> > * An example of the above could be an instance that requires more than one
> > * src/dst buffer per transaction.
> > */
> > -static void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
> > +void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
> > {
> > struct v4l2_m2m_dev *m2m_dev;
> > unsigned long flags_job, flags_out, flags_cap;
> > @@ -274,6 +274,7 @@ static void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
> >
> > v4l2_m2m_try_run(m2m_dev);
> > }
> > +EXPORT_SYMBOL(v4l2_m2m_try_schedule);
>
> Please use EXPORT_SYMBOL_GPL() instead.
Are you sure about this? I see that Pawel (added to Cc:) exported
v4l2_m2m_get_vq, v4l2_m2m_get_curr_priv, v4l2_m2m_mmap, and
v4l2_m2m_job_finish (which calls v4l2_m2m_try_schedule) also using
EXPORT_SYMBOL() while all other functions are EXPORT_SYMBOL_GPL()
Is there some reasoning behind this, or is it accidental?
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
