Hi Hans, On Monday 21 July 2014 23:43:16 Hans Verkuil wrote: > On 07/21/2014 10:39 PM, Laurent Pinchart wrote: > > The RGB666 pixel format doesn't include an alpha channel. Document it as > > such. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > > > .../DocBook/media/v4l/pixfmt-packed-rgb.xml | 20 +++++---------- > > 1 file changed, 6 insertions(+), 14 deletions(-) > > > > diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml > > b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml index > > 32feac9..c47692a 100644 > > --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml > > +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml > > @@ -330,20 +330,12 @@ colorspace > > <constant>V4L2_COLORSPACE_SRGB</constant>.</para>> > > <entry></entry> > > <entry>r<subscript>1</subscript></entry> > > <entry>r<subscript>0</subscript></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > - <entry></entry> > > + <entry>-</entry> > > + <entry>-</entry> > > + <entry>-</entry> > > + <entry>-</entry> > > + <entry>-</entry> > > + <entry>-</entry> > > Just to clarify: BGR666 is a three byte format, not a four byte format? Well... :-) Three drivers seem to support the BGR666 in mainline : sh_veu, s3c-camif and exynos4-is. Further investigation shows that the sh_veu driver lists the BGR666 format internally but doesn't expose it to userspace and doesn't actually support it, so we're down to two drivers. Looking at the S3C6410 datasheet, it's unclear how the hardware stores RGB666 pixels in memory. It could be either Byte 0 Byte 1 Byte 2 Byte 3 -------- ------RR RRRRGGGG GGBBBBBB or GGBBBBBB RRRRGGGG ------RR -------- None of those correspond to the RGB666 format defined in the spec. The Exynos4 FIMC isn't documented in the public datasheet, so I can't check how the format is defined. Furthermore, various Renesas video-related IP cores support many different RGB666 variants, on either 32 or 24 bits per pixel, with and without alpha. Beside a loud *sigh*, any comment ? :-) > > </row> > > <row id="V4L2-PIX-FMT-BGR24"> > > <entry><constant>V4L2_PIX_FMT_BGR24</constant></entry> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
