Re: [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I will apply that, thanks!

Could you and also Luis pay attention to commit message in future patches. I have had practically fixed almost every commit message from your patches. Long one liner just like this one is not correct. It should be short subject line and then explained more in the commit message body. I tend ask myself questions "why" and "how" and then write commit message based answers of those questions.

regards
Antti

On 07/18/2014 08:41 AM, Olli Salonen wrote:
Signed-off-by: Olli Salonen <olli.salonen@xxxxxx>
---
  drivers/media/tuners/si2157.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
index 329004f..4730f69 100644
--- a/drivers/media/tuners/si2157.c
+++ b/drivers/media/tuners/si2157.c
@@ -277,7 +277,7 @@ err:
  	return ret;
  }

-static const struct dvb_tuner_ops si2157_tuner_ops = {
+static const struct dvb_tuner_ops si2157_ops = {
  	.info = {
  		.name           = "Silicon Labs Si2157/Si2158",
  		.frequency_min  = 110000000,
@@ -317,7 +317,7 @@ static int si2157_probe(struct i2c_client *client,
  		goto err;

  	fe->tuner_priv = s;
-	memcpy(&fe->ops.tuner_ops, &si2157_tuner_ops,
+	memcpy(&fe->ops.tuner_ops, &si2157_ops,
  			sizeof(struct dvb_tuner_ops));

  	i2c_set_clientdata(client, s);


--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux