[linuxtv-media:master 452/499] drivers/staging/media/solo6x10/solo6x10-disp.c:225 solo_set_motion_block() error: potential null dereference 'buf'. (kzalloc returns null)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://linuxtv.org/media_tree.git master
head:   9409945c7ff7ba39727df8ede2551bd22e76b58b
commit: 761f9aa23f2ac187aa1bed58215f09f3c8456295 [452/499] [media] solo6x10: fix 'dma from stack' warning

drivers/staging/media/solo6x10/solo6x10-disp.c:225 solo_set_motion_block() error: potential null dereference 'buf'.  (kzalloc returns null)

vim +/buf +225 drivers/staging/media/solo6x10/solo6x10-disp.c

dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  209  				   (ch * SOLO_MOT_THRESH_SIZE * 2),
dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  210  				   val, SOLO_MOT_THRESH_SIZE);
dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  211  }
dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  212  
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  213  int solo_set_motion_block(struct solo_dev *solo_dev, u8 ch,
4063a3c78 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-06-10  214  		const u16 *thresholds)
dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  215  {
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  216  	const unsigned size = sizeof(u16) * 64;
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  217  	u32 off = SOLO_MOT_FLAG_AREA + ch * SOLO_MOT_THRESH_SIZE * 2;
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  218  	u16 *buf;
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  219  	int x, y;
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  220  	int ret = 0;
dcae5dacb drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-25  221  
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  222  	buf = kzalloc(size, GFP_KERNEL);
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  223  	for (y = 0; y < SOLO_MOTION_SZ; y++) {
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  224  		for (x = 0; x < SOLO_MOTION_SZ; x++)
4063a3c78 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-06-10 @225  			buf[x] = cpu_to_le16(thresholds[y * SOLO_MOTION_SZ + x]);
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  226  		ret |= solo_p2m_dma(solo_dev, 1, buf,
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  227  			SOLO_MOTION_EXT_ADDR(solo_dev) + off + y * size,
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  228  			size, 0, 0);
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  229  	}
761f9aa23 drivers/staging/media/solo6x10/solo6x10-disp.c Hans Verkuil 2014-02-07  230  	kfree(buf);
f5df0b7ff drivers/staging/media/solo6x10/disp.c          Hans Verkuil 2013-03-18  231  	return ret;
faa4fd2a0 drivers/staging/solo6x10/solo6010-disp.c       Ben Collins  2010-06-17  232  }
faa4fd2a0 drivers/staging/solo6x10/solo6010-disp.c       Ben Collins  2010-06-17  233  

:::::: The code at line 225 was first introduced by commit
:::::: 4063a3c781071e46aaf08e79c99ea822cbc0f089 [media] solo6x10: implement the new motion detection controls

:::::: TO: Hans Verkuil <hans.verkuil@xxxxxxxxx>
:::::: CC: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux