Hi Sakari, Thank you for the review. On Tuesday 01 July 2014 17:30:38 Sakari Ailus wrote: > On Tue, Jun 03, 2014 at 12:40:19PM +0200, Laurent Pinchart wrote: > > diff --git a/Makefile.am b/Makefile.am > > index 11baed1..35d0030 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -12,31 +12,32 @@ EXTRA_DIST = include COPYING.libv4l README.libv4l > > README.lib-multi-threading> > > # custom targets > > > > sync-with-kernel: > > - @if [ ! -f $(KERNEL_DIR)/include/uapi/linux/videodev2.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/fb.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-controls.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-common.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-subdev.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-mediabus.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/ivtv.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/frontend.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/dmx.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/audio.h -o \ > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/video.h ]; then \ > > + @if [ ! -f $(KERNEL_DIR)/usr/include/linux/videodev2.h -o \ > > Shouldn't you use $(INSTALL_HDR_PATH) instead of $(KERNEL_DIR)/usr? If the > user sets that, the headers won't be installed under usr. INSTALL_HDR_PATH is only set when running make headers_install in the kernel tree, not when running make sync-with-kernel in the media built tree. If we want to support syncing with kernel headers installed elsewhere we should add a new option to this Makefile. I haven't done so as the need isn't clear to me. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
