On 06/16/2014 02:04 PM, Hans Verkuil wrote: > Scott, > > Please verify that this solves your problem. It worked for me. Never mind, I'll repost the right patch in a minute. Hans > > Hans > > > When the audio encoding is changed the driver calls hdpvr_set_audio > with the current opt->audio_input value. However, that should have > been opt->audio_input + 1. So changing the audio encoding inadvertently > changes the input as well. This bug has always been there. > > The second bug was introduced in kernel 3.10 and that broke the > default_audio_input module option handling: the audio encoding was > never switched to AC3 if default_audio_input was set to 2 (SPDIF input). > > In addition, since starting with 3.10 the audio encoding is always set > at the start the first bug now always happens when the driver is loaded. > In the past this bug would only surface if the user would change the > audio encoding after the driver was loaded. > > Also fixes a small trivial typo (bufffer -> buffer). > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Tested-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Reported-by: Scott Doty <scott@xxxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx # for v3.10 and up > --- > drivers/media/usb/hdpvr/hdpvr-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c > index 0500c417..59f1dd4 100644 > --- a/drivers/media/usb/hdpvr/hdpvr-video.c > +++ b/drivers/media/usb/hdpvr/hdpvr-video.c > @@ -82,7 +82,7 @@ static void hdpvr_read_bulk_callback(struct urb *urb) > } > > /*=========================================================================*/ > -/* bufffer bits */ > +/* buffer bits */ > > /* function expects dev->io_mutex to be hold by caller */ > int hdpvr_cancel_queue(struct hdpvr_device *dev) > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
