Re: [PATCH 35/43] ARM: dts: imx6qdl: Add simple-bus to ipu compatibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Samstag, den 07.06.2014, 14:56 -0700 schrieb Steve Longerbeam:
> The IPU can have child devices now, so add "simple-bus" to
> compatible list to ensure creation of the children.
> 
> Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
> ---
>  .../bindings/staging/imx-drm/fsl-imx-drm.txt       |    6 ++++--
>  arch/arm/boot/dts/imx6q.dtsi                       |    2 +-
>  arch/arm/boot/dts/imx6qdl.dtsi                     |    2 +-
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> index 3be5ce7..dc759e4 100644
> --- a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> +++ b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> @@ -21,7 +21,9 @@ Freescale i.MX IPUv3
>  ====================
>  
>  Required properties:
> -- compatible: Should be "fsl,<chip>-ipu"
> +- compatible: Should be "fsl,<chip>-ipu". The IPU can also have child
> +  devices, so also must include "simple-bus" to ensure creation of the
> +  children.

This would be ok if the submodules (CSI, SMFC, IC, DC, DP, etc.) were
listed as subnodes (which I don't think is a good idea). As it stands,
this is a misuse of simple-bus, as the IPU does not provide access to
the subdevices you are going to add through a simple MMIO mapping.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux