Hi Laurent, Am Mittwoch, den 04.06.2014, 16:49 +0200 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. > > On Tuesday 03 June 2014 11:35:51 Philipp Zabel wrote: > > According to the publicly available MT9V032 data sheet, the reset bits are > > self clearing and the reset register always reads 0. The reset will be > > asserted for 15 SYSCLK cycles. Instead of writing 0 to the register, wait > > using ndelay. > > On the other hand, revision D of the datasheet states on page 71 ("Appendix A > - Serial Configurations, Figure 46: Stand-Alone Topology") that the typical > configuration of the sensor includes issuing a soft reset with > > 4. Issue a soft reset (set R0x0C[0] = 1 followed by R0x0C[0] = 0. > > I wonder whether it wouldn't be safer to keep the register write. Do you see > any adverse effect of keeping it ? No, writing 0 doesn't have any effect. Since the datasheet suggests doing this, let's just drop this patch and keep the code as is. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html