Hi Laurent, Laurent Pinchart wrote:
Hi Sakari, Thank you for the patch.
Thanks for the review!
On Tuesday 03 June 2014 12:25:16 Sakari Ailus wrote:
...
@@ -202,26 +251,20 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API) case VIDIOC_SUBDEV_G_FMT: { struct v4l2_subdev_format *format = arg; + int rval = check_format(sd, format);How about declaring the variable once only at the beginning of the function ?
I'll change that and resend. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
