On Tue, 3 Jun 2014 15:48:46 +0200
Antonio Ospite <ao2@xxxxxx> wrote:
> Fix a regression introduced in commit
> efc29f1764a30808ebf7b3e1d9bfa27b909bf641 (libv4lconvert: Reject too
> short source buffer before accessing it).
>
> The old code:
>
> case V4L2_PIX_FMT_Y10BPACK:
> ...
> if (result == 0 && src_size < (width * height * 10 / 8)) {
> V4LCONVERT_ERR("short y10b data frame\n");
> errno = EPIPE;
> result = -1;
> }
> ...
>
> meant to say "If the conversion was *successful* _but_ the frame size
> was invalid, then take the error path", but in
> efc29f1764a30808ebf7b3e1d9bfa27b909bf641 this (maybe weird) logic was
> misunderstood and the v4lconvert_convert_pixfmt() was made to return an
^^^
Dear committer, you can remove this "the", if you feel like it :)
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
