Re: [PATCH 0/6] Fix the format field order value for progressive subdevs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On 05/26/2014 09:05 PM, Laurent Pinchart wrote:
Hello,

This patch set fixes five sensor drivers and one camera interface driver to
return a format field order value set to V4L2_FIELD_NONE instead of
V4L2_FIELD_ANY.

V4L2_FIELD_ANY is used by applications to notify the driver that they don't
care about the interlaced video field order. The value must never be returned
by drivers, they must instead select a default field order they support.

The six drivers fixed by this patch all forgot to initialize the field order,
resulting in V4L2_FIELD_ANY (=0) being returned. As all those drivers support
progressive video only, make them return V4L2_FIELD_NONE instead.

Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
Cc: Sakari Ailus <sakari.ailus@xxxxxx>
Cc: Sangwook Lee <sangwook.lee@xxxxxxxxxx>

Laurent Pinchart (6):
   v4l: noon010p30: Return V4L2_FIELD_NONE from pad-level set format
   v4l: s5k4ecgx: Return V4L2_FIELD_NONE from pad-level set format
   v4l: s5k5baf: Return V4L2_FIELD_NONE from pad-level set format
   v4l: s5k6a3: Return V4L2_FIELD_NONE from pad-level set format
   v4l: smiapp: Return V4L2_FIELD_NONE from pad-level get/set format
   v4l: s3c-camif: Return V4L2_FIELD_NONE from pad-level set format

For patches 1...4, 6:

Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>

  drivers/media/i2c/noon010pc30.c                  | 1 +
  drivers/media/i2c/s5k4ecgx.c                     | 1 +
  drivers/media/i2c/s5k5baf.c                      | 2 ++
  drivers/media/i2c/s5k6a3.c                       | 1 +
  drivers/media/i2c/smiapp/smiapp-core.c           | 3 +++
  drivers/media/platform/s3c-camif/camif-capture.c | 2 ++
  6 files changed, 10 insertions(+)

--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux