Hi Philipp, Thank you for the patch. On Friday 23 May 2014 09:47:57 Philipp Zabel wrote: > Since (min_row_time - crop->width) can be negative, we have to do a signed > comparison here. Otherwise max_t casts the negative value to unsigned int > and sets min_hblank to that invalid value. > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > --- > drivers/media/i2c/mt9v032.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c > index 40172b8..4d7afad 100644 > --- a/drivers/media/i2c/mt9v032.c > +++ b/drivers/media/i2c/mt9v032.c > @@ -305,7 +305,7 @@ mt9v032_update_hblank(struct mt9v032 *mt9v032) > > if (mt9v032->version->version == MT9V034_CHIP_ID_REV1) > min_hblank += (mt9v032->hratio - 1) * 10; > - min_hblank = max_t(unsigned int, (int)mt9v032->model->data->min_row_time > - crop->width, > + min_hblank = max_t(int, (int)mt9v032->model->data->min_row_time > - crop->width, (int)min_hblank); As max_t now casts to int, wouldn't it make sense to remove the manual casts on both operands ? The first one is useless anyway, as the compiler will cast mt9v032->model->data->min_row_time back to an unsigned int as crop->width is unsigned. > hblank = max_t(unsigned int, mt9v032->hblank, min_hblank); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
