Re: [PATCH] technisat-sub2: Fix stream curruption on high bitrate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Em Wed, 16 Apr 2014 23:22:01 +0300
CrazyCat <crazycat69@xxxxxxxx> escreveu:

> Fix stream curruption on high bitrate (>60mbit).

Could you please better document this patch? 

I would be expecting a better description of the problem you faced,
the version of the board you have (assuming that different versions
might have different minimal intervals) and an lsusb -v output from
the board you faced issues, showing what the endpoint descriptors
say about that.

Btw, if those tables are ok, can't we just retrieve the information
directly from the descriptors, instead of hardcoding it, e. g
filling it with:

       interval = 1 << (ep->bInterval - 1);

at the board probing time, just like we did at changeset 1b3fd2d34266?

Regards,
Mauro

> 
> Signed-off-by: Evgeny Plehov <EvgenyPlehov@xxxxxxx>
> ---
>  drivers/media/usb/dvb-usb/technisat-usb2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c b/drivers/media/usb/dvb-usb/technisat-usb2.c
> index 420198f..4604c084 100644
> --- a/drivers/media/usb/dvb-usb/technisat-usb2.c
> +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
> @@ -711,7 +711,7 @@ static struct dvb_usb_device_properties technisat_usb2_devices = {
>  					.isoc = {
>  						.framesperurb = 32,
>  						.framesize = 2048,
> -						.interval = 3,
> +						.interval = 1,
>  					}
>  				}
>  			},
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux