On 05/17/2014 02:21 PM, Ezequiel Garcia wrote: > Hi Hans, > > On 09 May 12:34 PM, Hans Verkuil wrote: >> On 04/17/2014 02:28 PM, Ezequiel Garcia wrote: >>> Currently stk1160_read_reg() uses a stack-allocated char to get the >>> read control value. This is wrong because usb_control_msg() requires >>> a kmalloc-ed buffer. >>> >>> This commit fixes such issue by kmalloc'ating a 1-byte buffer to receive >>> the read value. >>> >>> While here, let's remove the urb_buf array which was meant for a similar >>> purpose, but never really used. >> >> Rather than allocating and freeing a buffer for every read_reg I would allocate >> this buffer in the probe function. >> >> That way this allocation is done only once. >> > > Hm... sorry for being so stubborn, but I've just noticed that having a > shared buffer would require adding a spinlock to protect it, where the current > proposal doesn't need it. > > Do you still think that's the right thing to do? I'm still not entirely happy, but I've decided to accept it. It's a bug and it needs to be fixed. Adding a mutex to protect the datastructure adds only more complexity and it not really worth the effort. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
