Hello Mauro Are you aware that using dynamic printk you can decide to print __func__ on demand? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/dynamic-debug-howto.txt#n213 Perhaps it is better to not add __func__ Regards! On Wed, May 21, 2014 at 8:19 PM, Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> wrote: > Sometimes, it helps to know how much data was received by > urb_completion. Add that information to the optional debug > log. > > Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx> > --- > drivers/media/usb/au0828/au0828-dvb.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-dvb.c b/drivers/media/usb/au0828/au0828-dvb.c > index 2019e4a168b2..ab5f93643021 100755 > --- a/drivers/media/usb/au0828/au0828-dvb.c > +++ b/drivers/media/usb/au0828/au0828-dvb.c > @@ -114,16 +114,20 @@ static void urb_completion(struct urb *purb) > int ptype = usb_pipetype(purb->pipe); > unsigned char *ptr; > > - dprintk(2, "%s()\n", __func__); > + dprintk(2, "%s: %d\n", __func__, purb->actual_length); > > - if (!dev) > + if (!dev) { > + dprintk(2, "%s: no dev!\n", __func__); > return; > + } > > - if (dev->urb_streaming == 0) > + if (dev->urb_streaming == 0) { > + dprintk(2, "%s: not streaming!\n", __func__); > return; > + } > > if (ptype != PIPE_BULK) { > - printk(KERN_ERR "%s() Unsupported URB type %d\n", > + printk(KERN_ERR "%s: Unsupported URB type %d\n", > __func__, ptype); > return; > } > -- > 1.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
