Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 05, 2014 at 11:52:46PM +0300, Antti Palosaari wrote:
> >845f3505 Antti Palosaari 2014-04-10  46
> >845f3505 Antti Palosaari 2014-04-10 @47  		if (!(cmd->args[0] >> 7) & 0x01) {
> >
> >This should be:						if (!((md->args[0] >> 7) & 0x01)) {
> >Otherwise it is a precedence error where it does the negate before the
> >bitwise AND.
> 
> That was already on my TODO list as daily media build test sparse
> warned it already http://hverkuil.home.xs4all.nl/logs/Monday.log
> 
> I am waiting for media/master kernel upgrades from 3.15-rc1 as that
> kernel will hang whole machine when em28xx driver used (em28xx
> driver is USB bridge for those si2168 and si2157).
> 

Wait, what?  This is a one liner.  I haven't understood the connection
with 3.15-rc1?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux