On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote: > On 05/17/2014 07:05 PM, Martin Kepplinger wrote: > >don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. > >use the common kernel coding style. > > > >Signed-off-by: Martin Kepplinger <martink@xxxxxxxxx> > > Reviewed-by: Antti Palosaari <crope@xxxxxx> > > >--- > >this applies to next-20140516. any more suggestions? > >more cleanup can be done when dprintk() is completely gone. > > Do you have the device? I am a bit reluctant patching that driver > without any testing as it has happened too many times something has > gone totally broken. Looking through the log the only time I see breakage is build breakage on allyesconfig. 1ec9a35 [media] staging: as102: Add missing function argument This was a compile warning and it definitely should have been caught before the code was submitted or merged, but it wasn't something people would hit in real life. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
