Hi Kamil, On 05/13/14 16:02, Kamil Debski wrote: > Hi, > > One small comment below, > >> -----Original Message----- >> From: Arun Kumar K [mailto:arunkk.samsung@xxxxxxxxx] On Behalf Of Arun >> Kumar K >> Sent: Wednesday, April 23, 2014 2:58 PM >> To: linux-media@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx >> Cc: k.debski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; posciak@xxxxxxxxxxxx; >> avnd.kiran@xxxxxxxxxxx; arunkk.samsung@xxxxxxxxx >> Subject: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc >> registers >> >> From: Kiran AVND <avnd.kiran@xxxxxxxxxxx> >> >> This patch is needed in preparation to add MFC V8 >> where the register offsets are changed w.r.t MFC V6/V7. >> >> This patch adds variants of MFC V6 and V7 while >> accessing MFC registers. Registers are kept in mfc context >> and are initialized to a particular MFC variant during probe, >> which is used instead of macros. >> >> This avoids duplication of the code for MFC variants >> V6 & V7, and reduces the if_else checks while accessing >> registers of different MFC variants. >> >> Signed-off-by: Kiran AVND <avnd.kiran@xxxxxxxxxxx> >> Signed-off-by: Pawel Osciak <posciak@xxxxxxxxxxxx> >> Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx> >> --- >> drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 + >> drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 1 + >> drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 6 + >> drivers/media/platform/s5p-mfc/s5p_mfc_opr.h | 254 +++++++++ >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 697 >> +++++++++++++++-------- >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h | 7 +- >> 6 files changed, 710 insertions(+), 256 deletions(-) >> [snip] >> if (p_h264->fmo) { >> @@ -988,10 +991,12 @@ static int s5p_mfc_set_enc_params_h264(struct >> s5p_mfc_ctx *ctx) >> case V4L2_MPEG_VIDEO_H264_FMO_MAP_TYPE_INTERLEAVED_SLICES: >> if (p_h264->fmo_slice_grp > 4) >> p_h264->fmo_slice_grp = 4; >> - for (i = 0; i < (p_h264->fmo_slice_grp & 0xF); i++) >> + for (i = 0; i < ARRAY_SIZE(p_h264->fmo_run_len) >> + && i < p_h264->fmo_slice_grp; i++) { > > What do you think about moving this to separate path? This seems > like it slipped with the register patches. > Sure I will remove this change from this patch. Thanks for spotting this. Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
