Re: [PATCH v2 01/26] omap3isp: stat: Rename IS_COHERENT_BUF to ISP_STAT_USES_DMAENGINE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On Thursday 01 May 2014 01:45:47 Sakari Ailus wrote:
> Hi Laurent,
> 
> Thanks for the set! I've been looking forward to see this! :)
> 
> On Mon, Apr 21, 2014 at 02:28:47PM +0200, Laurent Pinchart wrote:
> > The macro is meant to test whether the statistics engine uses an
> > external DMA engine to transfer data or supports DMA directly. As both
> > cases will be supported by DMA coherent buffers rename the macro to
> > ISP_STAT_USES_DMAENGINE for improved clarity.
> 
> Both use DMA, but the ISP just implements its own. How about calling the
> macro ISP_STAT_USES_SYSTEM_DMA instead? Up to you.

DMA engine is the Linux name for the system DMA engine API. It might indeed be 
slightly generic, but I'm not too sure whether ISP_STAT_USES_SYSTEM_DMA would 
be more descriptive. I suppose it depends on the background of the reader :-) 
If you insist I can change it.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux