Re: [PATCH] omap3isp: Make isp_register_entities() fail when sensor registration fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 30, 2014 at 11:04:14AM +0200, Peter Meerwald wrote:
> Hi,
> 
> > On Wed, Apr 30, 2014 at 10:14:31AM +0200, Peter Meerwald wrote:
> > > isp_register_entities() ignores registration failure of the sensor,
> > > /dev/video* devices are created nevertheless
> > > 
> > > if the sensor fails, all entities should not be created
> 
> > Why? In some cases it'd be nice to be able to use the devices that actually
> > are available. This certainly isn't something that should cause probe to
> > fail IMHO.
> 
> I see your point; e.g the ISP resizer could be used without a sensor

True. You might also be just missing the flash controller. Or you could have
multiple sensors connected.

> anyway, I can figure out later-on from the device topology that no sensor 
> is present

Good. :-)

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux