Am Montag, den 28.04.2014, 13:57 -0300 schrieb Fabio Estevam:
> If devm_request_threaded_irq() fails, we should better propagate the real error.
>
> Also, print out the error code in the dev_err message.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
Both look fine to me.
Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
2/2 trivially conflicts with "[PATCH] media: coda: Use full device name
for request_irq()" by Alexander Shiyan.
> ---
> drivers/media/platform/coda.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> index ba7cb3f..1360b91 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -3234,10 +3234,11 @@ static int coda_probe(struct platform_device *pdev)
> return irq;
> }
>
> - if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
> - IRQF_ONESHOT, CODA_NAME, dev) < 0) {
> - dev_err(&pdev->dev, "failed to request irq\n");
> - return -ENOENT;
> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
> + IRQF_ONESHOT, CODA_NAME, dev);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to request irq: %d\n", ret);
> + return ret;
> }
>
> /* Get IRAM pool from device tree or platform data */
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
