Ah, alas, Sakari is right. This should not be needed, since we memcpy
vb->v4l2_buf to this, also overwriting bytesused.
On Thu, Apr 10, 2014 at 10:08 AM, Pawel Osciak <pawel@xxxxxxxxxx> wrote:
> On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> The bytesused field of struct v4l2_buffer is not used for multiplanar
>> formats, so just zero it to prevent it from having some random value.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> Acked-by: Pawel Osciak <pawel@xxxxxxxxxx>
>
>> ---
>> drivers/media/v4l2-core/videobuf2-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
>> index 08152dd..ef7ef82 100644
>> --- a/drivers/media/v4l2-core/videobuf2-core.c
>> +++ b/drivers/media/v4l2-core/videobuf2-core.c
>> @@ -582,6 +582,7 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, struct v4l2_buffer *b)
>> * for it. The caller has already verified memory and size.
>> */
>> b->length = vb->num_planes;
>> + b->bytesused = 0;
>> memcpy(b->m.planes, vb->v4l2_planes,
>> b->length * sizeof(struct v4l2_plane));
>> } else {
>> --
>> 1.9.1
>>
>
>
>
> --
> Best regards,
> Pawel Osciak
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
