Hi James. On 16 March 2014 13:50, James Hogan <james@xxxxxxxxxxxxx> wrote: > Hi Antti, > > On Sunday 16 March 2014 10:34:31 Antti Seppälä wrote: >> > + >> > + /* all important bits of scancode should be set in mask */ >> > + if (~scancode->mask & 0x2fff) >> >> Do we want to be so restrictive here? In my opinion it's quite nice to >> be able to encode also the toggle bit if needed. Therefore a check >> against 0x3fff would be a better choice. >> >> I think the ability to encode toggle bit might also be nice to have >> for rc-5(x) also. >> > > I don't believe the toggle bit is encoded in the scancode though, so I'm not > sure it makes sense to treat it like that. I'm not an expert on RC-5 like > protocols or the use of the toggle bit though. > Well I'm not an expert either but at least streamzap tends to have the toggle bit enabled quite often when sending ir pulses. When decoding the toggle is always removed from the scancode but when encoding it would be useful to have the possibility to encode it in. This is because setting the toggle bit into wakeup makes it easier to wake the system with nuvoton hw as it is difficult to press the remote key short time enough (less than around 112ms) to generate a pulse without the toggle bit set. -Antti -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
