On 15 March 2014 01:04, James Hogan <james@xxxxxxxxxxxxx> wrote: > A recent discussion about proposed interfaces for setting up the > hardware wakeup filter lead to the conclusion that it could help to have > the generic capability to encode and modulate scancodes into raw IR > events so that drivers for hardware with a low level wake filter (on the > level of pulse/space durations) can still easily implement the higher > level scancode interface that is proposed. > > I posted an RFC patchset showing how this could work, and Antti Seppälä > posted additional patches to support rc5-sz and nuvoton-cir. This > patchset improves the original RFC patches and combines & updates > Antti's patches. > > I'm happy these patches are a good start at tackling the problem, as > long as Antti is happy with them and they work for him of course. > > Future work could include: > - Encoders for more protocols. > - Carrier signal events (no use unless a driver makes use of it). > > Patch 1 adds the new encode API. > Patches 2-3 adds some modulation helpers. > Patches 4-6 adds some raw encode implementations. > Patch 7 adds some rc-core support for encode based wakeup filtering. > Patch 8 adds debug loopback of encoded scancode when filter set. > Patch 9 (untested) adds encode based wakeup filtering to nuvoton-cir. > Hi James. This is looking very good. I've reviewed the series and have only minor comments to some of the patches which I'll post individually shortly. I've also tested the nuvoton with actual hardware with rc-5-sz and nec encoders and both generate wakeup samples correctly and can wake the system. While doing my tests I also noticed that there is a small bug in the wakeup_protocols handling where one can enable multiple protocols with the + -notation. E.g. echo "+nec +rc-5" > /sys/class/rc/rc0/wakeup_protocols shouldn't probably succeed. -Antti -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
