Em Wed, 12 Mar 2014 13:21:41 +0100 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > On 03/12/14 11:42, Mauro Carvalho Chehab wrote: > > Em Mon, 17 Feb 2014 10:57:29 +0100 > > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > > > >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > >> > >> Add core support for matrices. > > > > Again, this patch has negative values for array index. > > > > I'll stop analyzing here, as it is hard to keep the mind in a > > sane state seeing those crazy things ;) > > Rather than getting bogged down in these details can you please give > your opinion on the public API aspects. There is no point for me to > spend time on this and then get it NACKed because you don't like the > API itself and want something completely different. > > Internal things I can change, but I'm not going to spend a second on > that unless I know the concept stands. Otherwise it is wasted time. Ok, what patches after 16/35 contains the API bits? The changes I saw so far seem ok, with the adjustments I pointed. > This is something we need to improve on with regards to our > processes: when it comes to API enhancements you really need to be > involved earlier or it's going to be a huge waste of everyones time > it is gets NACked. Not to mention demotivating and frustrating for > all concerned. As I commented before: those complex API changes should ideally be discussed during our mini-summits, as it allows us to better understand the hole proposal and the taken approach. -- Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html