Re: [PATCH v2 12/48] ths8200: Add pad-level DV timings operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> The video enum_dv_timings and dv_timings_cap operations are deprecated.
> Implement the pad-level version of those operations to prepare for the
> removal of the video version.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Reviewed-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Regards,
--Prabhakar lad

> ---
>  drivers/media/i2c/ths8200.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/ths8200.c
> index f72561e..c4ec8b2 100644
> --- a/drivers/media/i2c/ths8200.c
> +++ b/drivers/media/i2c/ths8200.c
> @@ -410,6 +410,9 @@ static int ths8200_g_dv_timings(struct v4l2_subdev *sd,
>  static int ths8200_enum_dv_timings(struct v4l2_subdev *sd,
>                                    struct v4l2_enum_dv_timings *timings)
>  {
> +       if (timings->pad != 0)
> +               return -EINVAL;
> +
>         return v4l2_enum_dv_timings_cap(timings, &ths8200_timings_cap,
>                         NULL, NULL);
>  }
> @@ -417,6 +420,9 @@ static int ths8200_enum_dv_timings(struct v4l2_subdev *sd,
>  static int ths8200_dv_timings_cap(struct v4l2_subdev *sd,
>                                   struct v4l2_dv_timings_cap *cap)
>  {
> +       if (cap->pad != 0)
> +               return -EINVAL;
> +
>         *cap = ths8200_timings_cap;
>         return 0;
>  }
> @@ -430,10 +436,16 @@ static const struct v4l2_subdev_video_ops ths8200_video_ops = {
>         .dv_timings_cap = ths8200_dv_timings_cap,
>  };
>
> +static const struct v4l2_subdev_pad_ops ths8200_pad_ops = {
> +       .enum_dv_timings = ths8200_enum_dv_timings,
> +       .dv_timings_cap = ths8200_dv_timings_cap,
> +};
> +
>  /* V4L2 top level operation handlers */
>  static const struct v4l2_subdev_ops ths8200_ops = {
>         .core  = &ths8200_core_ops,
>         .video = &ths8200_video_ops,
> +       .pad = &ths8200_pad_ops,
>  };
>
>  static int ths8200_probe(struct i2c_client *client,
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux