On 07/03/14 16:45, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
Add nodes for the four video input channels on the R8A7790.
Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
This patch should have been preceded by the VIN driver patch and
bindings description, don't you think?
Given this is a pretty standard device and video input binding
as already described in the relevant documentation, didn't really
think it was necessary.
diff --git a/arch/arm/boot/dts/r8a7790.dtsi
b/arch/arm/boot/dts/r8a7790.dtsi
index a1e7c39..4c3eafb 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -395,6 +395,38 @@
status = "disabled";
};
+ vin0: vin@0xe6ef0000 {
ePAPR standard [1] tells us that:
The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model.
So, I would suggest something like "video". And remove "0x" from the
address part of the node name please.
vin is a reasonable contraction of video-input.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
