Re: [PATCH 0/5] rc: scancode filtering improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1 March 2014 01:17, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> These patches make some improvements relating to the recently added RC
> scancode filtering interface:
> - Patch 1 adds generic scancode filtering. This allows filtering to also
>   work for raw rc drivers and scancode drivers without filtering
>   capabilities.
> - Patches 2-4 future proof the sysfs API to allow a different wakeup
>   filter protocol to be set than the current protocol. A new
>   wakeup_protocols sysfs file is added which behaves similarly to the
>   protocols sysfs file but applies only to wakeup filters.
> - Finally patch 5 improves the driver interface so that changing either
>   the normal or wakeup protocol automatically causes the corresponding
>   filter to be refreshed to the driver, or failing that cleared. It also
>   ensures that the filter is turned off (and for wakeup that means
>   wakeup is disabled) if the protocol is set to none. This avoids the
>   driver having to maintain the filters, or even need a
>   change_wakeup_protocol() callback if there is only one wakeup protocol
>   allowed at a time.
>
> The patch "rc-main: store_filter: pass errors to userland" should
> probably be applied first.
>
> An updated img-ir v4 patchset which depends on this one will follow
> soon.
>
> Cc: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> Cc: "Bruno Prémont" <bonbons@xxxxxxxxxxxxxxxxx>
> Cc: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Cc: Sean Young <sean@xxxxxxxx>
> Cc: "David Härdeman" <david@xxxxxxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> Cc: "Antti Seppälä" <a.seppala@xxxxxxxxx>
>

After reviewing the series and porting my nuvoton changes to it I
haven't noticed any errors worth mentioning.
In fact I think this series is very well written and should be merged.

James, I hope you also have the time to submit the ir encoder series
for inclusion. :)

Reviewed-by: Antti Seppälä <a.seppala@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux