Hi, On 01/30/2014 01:14 PM, Dan Carpenter wrote: > Hello Jean-François Moine, > > The patch 8f12b1ab2fac: "[media] gspca - topro: New subdriver for > Topro webcams" from Sep 22, 2011, leads to the following > static checker warning: > drivers/media/usb/gspca/topro.c:4642 > sd_pkt_scan() warn: check 'data[]' for negative offsets s32min" > > drivers/media/usb/gspca/topro.c > 4632 data++; > > Should there be an "if (len < 8) return;" here? Thanks for the report, there were indeed several missing length checks in the packet parsing code in topro.c I've added a patch fixing this to my gspca tree for 3.15 . Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
