Hi Antti, Just one very tiny thing: in patch 1 in msi3101_template you added this line: + .debug = 0, Please remove. Fields initialized to 0 should in general be dropped since the compiler sets it to 0 already, and eventually the debug field will disappear anyway since you can set it by doing echo 1 >/sys/class/video4linux/video0/debug Regards, Hans On 02/10/2014 08:28 PM, Antti Palosaari wrote: > Split / group / merge changes as requested by Hans. > > Antti > > Antti Palosaari (5): > msi3101: convert to SDR API > msi001: Mirics MSi001 silicon tuner driver > msi3101: use msi001 tuner driver > MAINTAINERS: add msi001 driver > MAINTAINERS: add msi3101 driver > > MAINTAINERS | 20 + > drivers/staging/media/msi3101/Kconfig | 7 +- > drivers/staging/media/msi3101/Makefile | 1 + > drivers/staging/media/msi3101/msi001.c | 499 +++++++++ > drivers/staging/media/msi3101/sdr-msi3101.c | 1558 ++++++++++----------------- > 5 files changed, 1095 insertions(+), 990 deletions(-) > create mode 100644 drivers/staging/media/msi3101/msi001.c > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html